add mutation observer polyfill package

add mutation observer polyfill package
also enables custom element tests on all supported platforms

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25637

[Jennifer Messerly, 2013-07-30 03:27:23]

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/lib/...
File pkg/mutation_observer/lib/mutation_observer.js (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/lib/...
pkg/mutation_observer/lib/mutation_observer.js:187: get constructor() { return
MutationObserver; },
I have no idea why this is needed. Without it, the constructor is "Object" and
interceptor dispatch fails.

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/test...
File pkg/mutation_observer/test/mutation_observer_test.dart (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/test...
pkg/mutation_observer/test/mutation_observer_test.dart:33:
testMutationObserver() {
most of this test taken from dart:html version

[Siggi Cherem (dart-lang), 2013-07-30 16:44:47]

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/READ...
File pkg/mutation_observer/README.md (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/READ...
pkg/mutation_observer/README.md:16: <script
src="packages/mutation_observer/mutation_observer.debug.js"></script>
seems like there is no 'debug' in our package?

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/READ...
pkg/mutation_observer/README.md:22: <script
src="packages/mutation_observer/mutation_observer.min.js"></script>
seems that the 'min' file is missing, should we submit it too?

[blois, 2013-07-30 17:11:09]

Wondering about the package structure for general polyfills- we've discussed
some in the past moving more polyfills to ancillary JS files. Many of these
polyfills would be on the order of 1-5 lines of code- should each get its own
package, or is mutation observer special because of the size?

https://codereview.chromium.org/21109007/diff/1007/pkg/custom_element/test/cu...
File pkg/custom_element/test/custom_element_test.dart (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/custom_element/test/cu...
pkg/custom_element/test/custom_element_test.dart:19:
document.head.children.add(new ScriptElement()..text = code);
Is this test run under CSP? If so, does it need an exclusion?

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/READ...
File pkg/mutation_observer/README.md (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/READ...
pkg/mutation_observer/README.md:3: Mutation Observers provide a way to react to
changes in the DOM.
Maybe a comment as to what platforms need this (IE <= 10).

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/READ...
pkg/mutation_observer/README.md:16: <script
src="packages/mutation_observer/mutation_observer.debug.js"></script>
On 2013/07/30 16:44:47, Siggi Cherem (dart-lang) wrote:
> seems like there is no 'debug' in our package?

Convention is usually filename.js for debug and filename.min.js for the minified
version.

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/test...
File pkg/mutation_observer/test/mutation_observer_test.dart (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/test...
pkg/mutation_observer/test/mutation_observer_test.dart:106: // Bug 8076 that not
all optional params are optional in Dartium.
This bug probably does not affect this test.

[Jennifer Messerly, 2013-07-30 18:05:20]

@Pete, yes a single package for small polyfills might be nice. For packages that
are distinct git repositories in Polymer
(https://github.com/Polymer/MutationObservers) we should try to have a matching
package.

PTAL

https://codereview.chromium.org/21109007/diff/1007/pkg/custom_element/test/cu...
File pkg/custom_element/test/custom_element_test.dart (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/custom_element/test/cu...
pkg/custom_element/test/custom_element_test.dart:19:
document.head.children.add(new ScriptElement()..text = code);
On 2013/07/30 17:11:09, blois wrote:
> Is this test run under CSP? If so, does it need an exclusion?


I think it will be okay because Chrome is the only browser we test in CSP and it
supports MutationObserver natively. I ran test.py locally with Chrome and CSP
and it seemed to work. If not I can update the status file.

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/READ...
File pkg/mutation_observer/README.md (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/READ...
pkg/mutation_observer/README.md:3: Mutation Observers provide a way to react to
changes in the DOM.
On 2013/07/30 17:11:09, blois wrote:
> Maybe a comment as to what platforms need this (IE <= 10).

Done.

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/test...
File pkg/mutation_observer/test/mutation_observer_test.dart (right):

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/test...
pkg/mutation_observer/test/mutation_observer_test.dart:21: ..text =
'window.MutationObserver = void 0;'
This test is no longer run on CSP because it forces the polyfill.

https://codereview.chromium.org/21109007/diff/1007/pkg/mutation_observer/test...
pkg/mutation_observer/test/mutation_observer_test.dart:106: // Bug 8076 that not
all optional params are optional in Dartium.
On 2013/07/30 17:11:09, blois wrote:
> This bug probably does not affect this test.

done, removed comment

[Siggi Cherem (dart-lang), 2013-07-30 19:37:00]

lgtm

[Jennifer Messerly, 2013-07-30 20:45:54]

I noticed some missing dependencies in the pubspec. added

[Jennifer Messerly, 2013-07-30 20:48:54]

Committed patchset #4 manually as r25637 (presubmit successful).