Issue 211033003: Add ie11 suppressions to pkg.status, and a new ie9 failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211033003: Add ie11 suppressions to pkg.status, and a new ie9 failure. (Closed)

Created:
6 years, 9 months ago by Bill Hesse

Modified:
6 years, 8 months ago

Reviewers:
ricow1, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add ie11 suppressions to pkg.status, and a new ie9 failure. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34353

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	dart/pkg/pkg.status	View		3 chunks	+5 lines, -4 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Committed patchset #1 manually as r34353 (presubmit successful).

6 years, 9 months ago (2014-03-25 12:40:45 UTC) #3

Emily Fortuna

https://codereview.chromium.org/211033003/diff/1/dart/pkg/pkg.status File dart/pkg/pkg.status (left): https://codereview.chromium.org/211033003/diff/1/dart/pkg/pkg.status#oldcode345 dart/pkg/pkg.status:345: [ $runtime == safari || $runtime == chrome || ...

6 years, 8 months ago (2014-03-28 16:49:05 UTC) #4

Bill Hesse

6 years, 8 months ago (2014-03-28 16:55:56 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/211033003/diff/1/dart/pkg/pkg.status
File dart/pkg/pkg.status (left):

https://codereview.chromium.org/211033003/diff/1/dart/pkg/pkg.status#oldcode345
dart/pkg/pkg.status:345: [ $runtime == safari || $runtime == chrome || $runtime
== ie9 || $runtime == ff || $runtime == ie10 ]
On 2014/03/28 16:49:06, Emily Fortuna wrote:
> was this an accident that $runtime==ff was deleted?

Yes it was, and it was restored in a later CL.  I should have noted it in this
CL too.  Restored in https://codereview.chromium.org/211243002/

Expand Messages | Collapse Messages