Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 21097006: Add a library name for cancelable_future.dart (Closed)

Created:
7 years, 4 months ago by nweiz
Modified:
7 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a library name for cancelable_future.dart R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/barback/lib/src/cancelable_future.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 4 months ago (2013-07-31 00:24:13 UTC) #1
Bob Nystrom
LGTM.
7 years, 4 months ago (2013-07-31 00:24:37 UTC) #2
nweiz
Committed patchset #1 manually as r25653 (presubmit successful).
7 years, 4 months ago (2013-07-31 00:25:00 UTC) #3
rmacnak
7 years, 4 months ago (2013-07-31 00:38:30 UTC) #4
Message was sent while issue was closed.
On 2013/07/31 00:25:00, nweiz wrote:
> Committed patchset #1 manually as r25653 (presubmit successful).

library name must appear before all imports...

Powered by Google App Engine
This is Rietveld 408576698