Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 21093005: remove bindModel, the same effect can be achieved through createInstance (Closed)

Created:
7 years, 4 months ago by Jennifer Messerly
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

remove bindModel, the same effect can be achieved through createInstance partial port of https://github.com/Polymer/mdv/commit/86c0d3d8059eebbafab6d919cd805373951873ea R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25658

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -181 lines) Patch
M pkg/mdv/lib/mdv.dart View 1 1 chunk +3 lines, -17 lines 0 comments Download
M pkg/mdv/test/template_element_test.dart View 1 1 chunk +9 lines, -11 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 12 chunks +51 lines, -51 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 12 chunks +51 lines, -51 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 12 chunks +51 lines, -51 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
https://codereview.chromium.org/21093005/diff/3001/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/21093005/diff/3001/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode961 tools/dom/templates/html/impl/impl_Element.darttemplate:961: DocumentFragment createInstance(model, [BindingDelegate delegate]) { it's not always easy ...
7 years, 4 months ago (2013-07-31 02:47:02 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 4 months ago (2013-07-31 02:49:18 UTC) #2
Siggi Cherem (dart-lang)
ps: note that we'll likely need to fix the use of this in the PolymerElement ...
7 years, 4 months ago (2013-07-31 02:49:53 UTC) #3
Jennifer Messerly
On 2013/07/31 02:49:53, Siggi Cherem (dart-lang) wrote: > ps: note that we'll likely need to ...
7 years, 4 months ago (2013-07-31 02:50:16 UTC) #4
Jennifer Messerly
7 years, 4 months ago (2013-07-31 02:51:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r25658 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698