Inline CreateLibraryMirror.

Inline CreateLibraryMirror.

BUG=
R=asiva@google.com, rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25640

[rmacnak, 2013-07-30 18:55:09]

lgtm

[siva, 2013-07-30 20:42:27]

lgtm

https://codereview.chromium.org/21092004/diff/2001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/21092004/diff/2001/runtime/lib/mirrors.cc#new...
runtime/lib/mirrors.cc:437: args.SetAt(2, String::Handle(lib.url()));
Small nit, you could save one Handle here by doing;

String& str = String::Handle();
str = lib.name();
args.Set(1, str);
str = lib.url();
args.Set(2, str);

[Michael Lippautz (Google), 2013-07-30 20:52:14]

https://codereview.chromium.org/21092004/diff/2001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/21092004/diff/2001/runtime/lib/mirrors.cc#new...
runtime/lib/mirrors.cc:437: args.SetAt(2, String::Handle(lib.url()));
On 2013/07/30 20:42:27, siva wrote:
> Small nit, you could save one Handle here by doing;
> 
> String& str = String::Handle();
> str = lib.name();
> args.Set(1, str);
> str = lib.url();
> args.Set(2, str);

Done.

[Michael Lippautz (Google), 2013-07-30 20:52:52]

Committed patchset #3 manually as r25640 (presubmit successful).