Add a test suite for Try Dart!

Add a test suite for Try Dart!

R=kasperl@google.com, lukechurch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34360

[kasperl, 2014-03-25 09:48:07]

LGTM!

https://codereview.chromium.org/210873002/diff/1/dart/tests/try/paste_test.dart
File dart/tests/try/paste_test.dart (right):

https://codereview.chromium.org/210873002/diff/1/dart/tests/try/paste_test.da...
dart/tests/try/paste_test.dart:5: //
SharedOptions=--package-root=sdk/lib/_internal/ -v
Get rid of -v.

https://codereview.chromium.org/210873002/diff/1/dart/tests/try/try.status
File dart/tests/try/try.status (right):

https://codereview.chromium.org/210873002/diff/1/dart/tests/try/try.status#ne...
dart/tests/try/try.status:7: *: skip
skip -> Skip?

[lukechurch, 2014-03-25 11:31:36]

lgtm

Could we structure the tests so it's clear what they're covering?

I've had difficulties as UIs grow more complicated for it to be obvious which
tests target the whole application stack, which target the implementation
services (as I think this does), and which target subcomponents. This has made
hunting the source of regressions in UI behaviour a lot quicker for me in the
past

[lukechurch, 2014-03-25 11:32:40]

On 2014/03/25 11:31:36, lukechurch wrote:
> lgtm
> 
> Could we structure the tests so it's clear what they're covering?
> 
> I've had difficulties as UIs grow more complicated for it to be obvious which
> tests target the whole application stack, which target the implementation
> services (as I think this does), and which target subcomponents. This has made
> hunting the source of regressions in UI behaviour a lot quicker for me in the
> past

Sorry e.g. if this wasn't clear, the test is called 'paste_test' but doesn't
actually test the interaction of pasting. It test the side effect that pasting
would hopefully cause. Does that make sense?

[ahe, 2014-03-25 11:54:17]

On 2014/03/25 11:32:40, lukechurch wrote:
> On 2014/03/25 11:31:36, lukechurch wrote:
> > lgtm
> > 
> > Could we structure the tests so it's clear what they're covering?
> > 
> > I've had difficulties as UIs grow more complicated for it to be obvious
which
> > tests target the whole application stack, which target the implementation
> > services (as I think this does), and which target subcomponents. This has
made
> > hunting the source of regressions in UI behaviour a lot quicker for me in
the
> > past
> 
> Sorry e.g. if this wasn't clear, the test is called 'paste_test' but doesn't
> actually test the interaction of pasting. It test the side effect that pasting
> would hopefully cause. Does that make sense?

Luke,

I'm not sure what you're saying: is the name of the test wrong, or would like
like more subdirectories? Or both?

Cheers,
Peter

[lukechurch, 2014-03-25 12:34:51]

On 2014/03/25 11:54:17, ahe wrote:
> On 2014/03/25 11:32:40, lukechurch wrote:
> > On 2014/03/25 11:31:36, lukechurch wrote:
> > > lgtm
> > > 
> > > Could we structure the tests so it's clear what they're covering?
> > > 
> > > I've had difficulties as UIs grow more complicated for it to be obvious
> which
> > > tests target the whole application stack, which target the implementation
> > > services (as I think this does), and which target subcomponents. This has
> made
> > > hunting the source of regressions in UI behaviour a lot quicker for me in
> the
> > > past
> > 
> > Sorry e.g. if this wasn't clear, the test is called 'paste_test' but doesn't
> > actually test the interaction of pasting. It test the side effect that
pasting
> > would hopefully cause. Does that make sense?
> 
> Luke,
> 
> I'm not sure what you're saying: is the name of the test wrong, or would like
> like more subdirectories? Or both?
> 
> Cheers,
> Peter

I think both :)

[ahe, 2014-03-25 12:50:51]

On 2014/03/25 12:34:51, lukechurch wrote:
> On 2014/03/25 11:54:17, ahe wrote:
> > On 2014/03/25 11:32:40, lukechurch wrote:
> > > On 2014/03/25 11:31:36, lukechurch wrote:
> > > > lgtm
> > > > 
> > > > Could we structure the tests so it's clear what they're covering?
> > > > 
> > > > I've had difficulties as UIs grow more complicated for it to be obvious
> > which
> > > > tests target the whole application stack, which target the
implementation
> > > > services (as I think this does), and which target subcomponents. This
has
> > made
> > > > hunting the source of regressions in UI behaviour a lot quicker for me
in
> > the
> > > > past
> > > 
> > > Sorry e.g. if this wasn't clear, the test is called 'paste_test' but
doesn't
> > > actually test the interaction of pasting. It test the side effect that
> pasting
> > > would hopefully cause. Does that make sense?
> > 
> > Luke,
> > 
> > I'm not sure what you're saying: is the name of the test wrong, or would
like
> > like more subdirectories? Or both?
> > 
> > Cheers,
> > Peter
> 
> I think both :)

OK. Could you give me concrete suggestions?

[lukechurch, 2014-03-25 13:54:04]

On 2014/03/25 12:50:51, ahe wrote:
> On 2014/03/25 12:34:51, lukechurch wrote:
> > On 2014/03/25 11:54:17, ahe wrote:
> > > On 2014/03/25 11:32:40, lukechurch wrote:
> > > > On 2014/03/25 11:31:36, lukechurch wrote:
> > > > > lgtm
> > > > > 
> > > > > Could we structure the tests so it's clear what they're covering?
> > > > > 
> > > > > I've had difficulties as UIs grow more complicated for it to be
obvious
> > > which
> > > > > tests target the whole application stack, which target the
> implementation
> > > > > services (as I think this does), and which target subcomponents. This
> has
> > > made
> > > > > hunting the source of regressions in UI behaviour a lot quicker for me
> in
> > > the
> > > > > past
> > > > 
> > > > Sorry e.g. if this wasn't clear, the test is called 'paste_test' but
> doesn't
> > > > actually test the interaction of pasting. It test the side effect that
> > pasting
> > > > would hopefully cause. Does that make sense?
> > > 
> > > Luke,
> > > 
> > > I'm not sure what you're saying: is the name of the test wrong, or would
> like
> > > like more subdirectories? Or both?
> > > 
> > > Cheers,
> > > Peter
> > 
> > I think both :)
> 
> OK. Could you give me concrete suggestions?

As per our discussion:

Happy without sub folders.
Consider renaming test to: testPasteContentRewriting
Consider renaming 'inputPre' to 'mainEditorPane'

Thanks

[ahe, 2014-03-25 14:00:55]

On 2014/03/25 13:54:04, lukechurch wrote:
> On 2014/03/25 12:50:51, ahe wrote:
> > On 2014/03/25 12:34:51, lukechurch wrote:
> > > On 2014/03/25 11:54:17, ahe wrote:
> > > > On 2014/03/25 11:32:40, lukechurch wrote:
> > > > > On 2014/03/25 11:31:36, lukechurch wrote:
> > > > > > lgtm
> > > > > > 
> > > > > > Could we structure the tests so it's clear what they're covering?
> > > > > > 
> > > > > > I've had difficulties as UIs grow more complicated for it to be
> obvious
> > > > which
> > > > > > tests target the whole application stack, which target the
> > implementation
> > > > > > services (as I think this does), and which target subcomponents.
This
> > has
> > > > made
> > > > > > hunting the source of regressions in UI behaviour a lot quicker for
me
> > in
> > > > the
> > > > > > past
> > > > > 
> > > > > Sorry e.g. if this wasn't clear, the test is called 'paste_test' but
> > doesn't
> > > > > actually test the interaction of pasting. It test the side effect that
> > > pasting
> > > > > would hopefully cause. Does that make sense?
> > > > 
> > > > Luke,
> > > > 
> > > > I'm not sure what you're saying: is the name of the test wrong, or would
> > like
> > > > like more subdirectories? Or both?
> > > > 
> > > > Cheers,
> > > > Peter
> > > 
> > > I think both :)
> > 
> > OK. Could you give me concrete suggestions?
> 
> As per our discussion:
> 
> Happy without sub folders.
> Consider renaming test to: testPasteContentRewriting

That would be paste_content_rewriting_test.dart with our conventions.

> Consider renaming 'inputPre' to 'mainEditorPane'

Will do in another CL.

> 
> Thanks

[ahe, 2014-03-25 14:06:46]

Luke, Kasper: thank you for your suggestions!

https://codereview.chromium.org/210873002/diff/1/dart/tests/try/paste_test.dart
File dart/tests/try/paste_test.dart (right):

https://codereview.chromium.org/210873002/diff/1/dart/tests/try/paste_test.da...
dart/tests/try/paste_test.dart:5: //
SharedOptions=--package-root=sdk/lib/_internal/ -v
On 2014/03/25 09:48:07, kasperl wrote:
> Get rid of -v.

Done.

https://codereview.chromium.org/210873002/diff/1/dart/tests/try/try.status
File dart/tests/try/try.status (right):

https://codereview.chromium.org/210873002/diff/1/dart/tests/try/try.status#ne...
dart/tests/try/try.status:7: *: skip
On 2014/03/25 09:48:07, kasperl wrote:
> skip -> Skip?

Done.

[ahe, 2014-03-25 14:08:48]

Committed patchset #2 manually as r34360 (presubmit successful).