Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 21085010: Added hasProperty matcher. (Closed)

Created:
7 years, 4 months ago by gram
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -10 lines) Patch
A pkg/unittest/lib/mirror_matchers.dart View 1 1 chunk +92 lines, -0 lines 0 comments Download
M pkg/unittest/lib/src/core_matchers.dart View 1 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
A pkg/unittest/test/mirror_matchers_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gram
7 years, 4 months ago (2013-07-31 00:16:47 UTC) #1
Siggi Cherem (dart-lang)
given that matches are so popularly used, I'm afraid of including dart:mirrors by default. Can ...
7 years, 4 months ago (2013-07-31 00:23:30 UTC) #2
gram
PTAL
7 years, 4 months ago (2013-07-31 01:13:45 UTC) #3
Siggi Cherem (dart-lang)
lgtm!
7 years, 4 months ago (2013-07-31 01:45:01 UTC) #4
gram
7 years, 4 months ago (2013-07-31 16:03:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r25667 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698