Issue 21085008: Fixing some SVG collections not working on Dartium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21085008: Fixing some SVG collections not working on Dartium (Closed)

Created:
7 years, 4 months ago by blois

Modified:
7 years, 4 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing some SVG collections not working on Dartium. Issue was that we were generating code calling native methods which were not present for these SVG collections. BUG=11204 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=25682

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -10 lines)			Patch
M	sdk/lib/svg/dartium/svg_dartium.dart	View	5 chunks	+5 lines, -10 lines	0 comments	Download
M	tests/html/svgelement_test.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	2 chunks	+19 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

blois

7 years, 4 months ago (2013-07-31 20:18:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25682 (presubmit successful).