Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21085005: Rename int{x,32,64} to Int{X,32,64} in line with naming guidelines. (Closed)

Created:
7 years, 4 months ago by Chris Bracken
Modified:
7 years, 4 months ago
Reviewers:
justinfagnani
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename int{x,32,64} to Int{X,32,64} in line with naming guidelines. BUG= R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=25584

Patch Set 1 #

Total comments: 2

Patch Set 2 : Intx -> IntX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+841 lines, -841 lines) Patch
M pkg/fixnum/lib/src/int32.dart View 1 10 chunks +76 lines, -76 lines 0 comments Download
M pkg/fixnum/lib/src/int64.dart View 1 33 chunks +131 lines, -131 lines 0 comments Download
M pkg/fixnum/lib/src/intx.dart View 1 2 chunks +29 lines, -29 lines 0 comments Download
M pkg/fixnum/test/int_32_test.dart View 1 chunk +158 lines, -158 lines 0 comments Download
M pkg/fixnum/test/int_64_test.dart View 1 chunk +447 lines, -447 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Chris Bracken
7 years, 4 months ago (2013-07-29 19:49:13 UTC) #1
justinfagnani
https://codereview.chromium.org/21085005/diff/1/pkg/fixnum/lib/src/intx.dart File pkg/fixnum/lib/src/intx.dart (right): https://codereview.chromium.org/21085005/diff/1/pkg/fixnum/lib/src/intx.dart#newcode10 pkg/fixnum/lib/src/intx.dart:10: abstract class Intx implements Comparable { IntX maybe?
7 years, 4 months ago (2013-07-29 20:15:13 UTC) #2
Chris Bracken
https://codereview.chromium.org/21085005/diff/1/pkg/fixnum/lib/src/intx.dart File pkg/fixnum/lib/src/intx.dart (right): https://codereview.chromium.org/21085005/diff/1/pkg/fixnum/lib/src/intx.dart#newcode10 pkg/fixnum/lib/src/intx.dart:10: abstract class Intx implements Comparable { On 2013/07/29 20:15:13, ...
7 years, 4 months ago (2013-07-29 20:28:09 UTC) #3
justinfagnani
lgtm
7 years, 4 months ago (2013-07-29 21:09:57 UTC) #4
Chris Bracken
7 years, 4 months ago (2013-07-29 21:20:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r25584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698