Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 210783004: Get the correct version of ie from the reg database (Closed)

Created:
6 years, 9 months ago by ricow1
Modified:
6 years, 9 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get the correct version of ie from the reg database version is 9.0.FOO.BAR on ie9 9.10.XFOO.XBAR on ie10 9.11.ZFOO.ZBAR on ie11 svcVersion is a more sane number, i.e., on ie10 it is 10.0.9200.16843 (atm) and on ie11 it is 11.0.9600.16521 (atm) R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/dart/browser_controller.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 9 months ago (2014-03-25 09:36:50 UTC) #1
Bill Hesse
lgtm
6 years, 9 months ago (2014-03-25 10:34:41 UTC) #2
ricow1
6 years, 9 months ago (2014-03-25 12:48:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698