Issue 21074002: Remove support for missing part-of tag.

Issue 21074002: Remove support for missing part-of tag. (Closed)

Created:
7 years, 4 months ago by Johnni Winther

Modified:
7 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove support for missing part-of tag. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=25855

Patch Set 2 : Fix extra tests. #

Total comments: 2

Patch Set 3 : Rebased and updated cf. comment. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -27 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View	1 2	1 chunk	+1 line, -11 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/deprecated_features_test.dart	View		3 chunks	+1 line, -10 lines	0 comments	Download
M	tests/compiler/dart2js_extra/inline_position_crash_source.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js_extra/inline_position_crash_test.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js_extra/source_mapping_crash_source.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/library_juxtaposition_part.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	tests/language/missing_part_of_tag_part.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tests/language/missing_part_of_tag_test.dart	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/21074002/diff/4001/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/21074002/diff/4001/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode371 sdk/lib/_internal/compiler/implementation/library_loader.dart:371: compiler.reportMessage( compiler.reportError(unit, MessageKind.MISSING_PART_OF_TAG);

7 years, 4 months ago (2013-08-06 14:22:06 UTC) #2

Johnni Winther

https://codereview.chromium.org/21074002/diff/4001/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/21074002/diff/4001/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode371 sdk/lib/_internal/compiler/implementation/library_loader.dart:371: compiler.reportMessage( On 2013/08/06 14:22:06, ahe wrote: > compiler.reportError(unit, MessageKind.MISSING_PART_OF_TAG); ...

7 years, 4 months ago (2013-08-07 06:00:51 UTC) #3

Johnni Winther

7 years, 4 months ago (2013-08-07 06:02:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r25855 (presubmit successful).

Expand Messages | Collapse Messages