Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 21065002: Treat ambiguous types as malformed. (Closed)

Created:
7 years, 4 months ago by Johnni Winther
Modified:
7 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Treat ambiguous types as malformed. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=25605

Patch Set 1 #

Patch Set 2 : Status updated. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -238 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 5 chunks +0 lines, -71 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 4 chunks +1 line, -39 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 8 chunks +13 lines, -26 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 6 chunks +8 lines, -57 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 4 chunks +0 lines, -37 lines 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +11 lines, -0 lines 1 comment Download
M tests/language/language.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/library_ambiguous_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 4 months ago (2013-07-29 12:01:22 UTC) #1
ahe
LGTM! https://codereview.chromium.org/21065002/diff/4001/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/21065002/diff/4001/tests/co19/co19-dart2js.status#newcode561 tests/co19/co19-dart2js.status:561: Language/13_Libraries_and_Scripts/1_Imports_A03_t02: Fail # 481 Fail, OK?
7 years, 4 months ago (2013-07-29 12:33:19 UTC) #2
Johnni Winther
7 years, 4 months ago (2013-07-30 05:59:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25605 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698