Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 21049012: Update VM to handle malformed types according to revised spec (issues 9055, (Closed)

Created:
7 years, 4 months ago by regis
Modified:
7 years, 4 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update VM to handle malformed types according to revised spec (issues 9055, 12105, 7247). Update language tests. Update status files. Allow map literals to specify a key type that is not a String. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -387 lines) Patch
M runtime/lib/map_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/object.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/class_finalizer.h View 4 chunks +4 lines, -12 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 19 chunks +63 lines, -104 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 23 chunks +187 lines, -147 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 4 chunks +67 lines, -19 lines 0 comments Download
M tests/language/instanceof3_test.dart View 6 chunks +16 lines, -16 lines 0 comments Download
M tests/language/isnot_malformed_type_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/language/language.status View 4 chunks +0 lines, -48 lines 0 comments Download
M tests/language/language_dart2js.status View 4 chunks +5 lines, -6 lines 0 comments Download
M tests/language/malformed_test.dart View 4 chunks +24 lines, -16 lines 0 comments Download
M tests/language/mixin_type_parameters_errors_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 4 months ago (2013-07-31 00:58:20 UTC) #1
srdjan
lgtm
7 years, 4 months ago (2013-07-31 14:32:58 UTC) #2
regis
7 years, 4 months ago (2013-07-31 15:20:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698