Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 210463002: Switch the command line Dart-based analyzer back to the synchronous API. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Switch the command line Dart-based analyzer back to the synchronous API. This improves timing for dart2js analysis from 8000 ms to 7700 ms (vs. 7300 ms for Java-based analyzer). R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/bin/analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 9 months ago (2014-03-24 21:30:43 UTC) #1
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-24 21:31:17 UTC) #2
scheglov
6 years, 9 months ago (2014-03-24 21:32:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698