Issue 210413002: pkg/unittest: using matcher and mock from packages

Issue 210413002: pkg/unittest: using matcher and mock from packages (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: using matcher and mock from packages R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34329

Patch Set 3 : releasing v0.10.1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -6246 lines)			Patch
M	pkg/pkg.status	View		7 chunks	+4 lines, -13 lines	0 comments	Download
M	pkg/unittest/CHANGELOG.md	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	pkg/unittest/lib/matcher.dart	View		1 chunk	+7 lines, -32 lines	0 comments	Download
M	pkg/unittest/lib/mirror_matchers.dart	View		1 chunk	+7 lines, -94 lines	0 comments	Download
M	pkg/unittest/lib/mock.dart	View		1 chunk	+6 lines, -1546 lines	0 comments	Download
D	pkg/unittest/lib/src/core_matchers.dart	View		1 chunk	+0 lines, -875 lines	0 comments	Download
D	pkg/unittest/lib/src/description.dart	View		1 chunk	+0 lines, -78 lines	0 comments	Download
D	pkg/unittest/lib/src/expect.dart	View		1 chunk	+0 lines, -176 lines	0 comments	Download
D	pkg/unittest/lib/src/future_matchers.dart	View		1 chunk	+0 lines, -68 lines	0 comments	Download
D	pkg/unittest/lib/src/interfaces.dart	View		1 chunk	+0 lines, -103 lines	0 comments	Download
D	pkg/unittest/lib/src/iterable_matchers.dart	View		1 chunk	+0 lines, -273 lines	0 comments	Download
D	pkg/unittest/lib/src/map_matchers.dart	View		1 chunk	+0 lines, -57 lines	0 comments	Download
D	pkg/unittest/lib/src/numeric_matchers.dart	View		1 chunk	+0 lines, -234 lines	0 comments	Download
D	pkg/unittest/lib/src/operator_matchers.dart	View		1 chunk	+0 lines, -176 lines	0 comments	Download
D	pkg/unittest/lib/src/pretty_print.dart	View		1 chunk	+0 lines, -110 lines	0 comments	Download
D	pkg/unittest/lib/src/string_matchers.dart	View		1 chunk	+0 lines, -204 lines	0 comments	Download
M	pkg/unittest/lib/unittest.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/unittest/pubspec.yaml	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
D	pkg/unittest/test/matchers_minified_test.dart	View		1 chunk	+0 lines, -134 lines	0 comments	Download
D	pkg/unittest/test/matchers_test.dart	View		1 chunk	+0 lines, -808 lines	0 comments	Download
D	pkg/unittest/test/matchers_unminified_test.dart	View		1 chunk	+0 lines, -130 lines	0 comments	Download
D	pkg/unittest/test/mirror_matchers_test.dart	View		1 chunk	+0 lines, -45 lines	0 comments	Download
D	pkg/unittest/test/mock_regexp_negative_test.dart	View		1 chunk	+0 lines, -16 lines	0 comments	Download
D	pkg/unittest/test/mock_stepwise_negative_test.dart	View		1 chunk	+0 lines, -19 lines	0 comments	Download
D	pkg/unittest/test/mock_test.dart	View		1 chunk	+0 lines, -736 lines	0 comments	Download
D	pkg/unittest/test/pretty_print_minified_test.dart	View		1 chunk	+0 lines, -61 lines	0 comments	Download
D	pkg/unittest/test/pretty_print_test.dart	View		1 chunk	+0 lines, -196 lines	0 comments	Download
D	pkg/unittest/test/pretty_print_unminified_test.dart	View		1 chunk	+0 lines, -58 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/210413002/diff/20001/pkg/unittest/lib/unittest.dart File pkg/unittest/lib/unittest.dart (right): https://codereview.chromium.org/210413002/diff/20001/pkg/unittest/lib/unittest.dart#newcode154 pkg/unittest/lib/unittest.dart:154: configureExpectFailureHandler, TestFailure, wrapAsync; we should probably rename TestFailure ...

6 years, 9 months ago (2014-03-24 21:11:44 UTC) #2

kevmoo

Also bumped the pubspec to release 0.10.1 https://codereview.chromium.org/210413002/diff/20001/pkg/unittest/lib/unittest.dart File pkg/unittest/lib/unittest.dart (right): https://codereview.chromium.org/210413002/diff/20001/pkg/unittest/lib/unittest.dart#newcode154 pkg/unittest/lib/unittest.dart:154: configureExpectFailureHandler, TestFailure, ...

6 years, 9 months ago (2014-03-24 21:16:54 UTC) #3

kevmoo

6 years, 9 months ago (2014-03-24 21:17:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r34329 (presubmit successful).

Expand Messages | Collapse Messages