Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 21038003: Move VM-specific part of a test into a separate vm_test file. (Closed)

Created:
7 years, 4 months ago by Florian Schneider
Modified:
7 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move VM-specific part of a test into a separate vm_test file. This way dart2js runs the rest of the tests included in the original file. BUG=https://code.google.com/p/dart/issues/detail?id=11937 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=25560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -16 lines) Patch
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/no_such_method_dispatcher_test.dart View 2 chunks +0 lines, -15 lines 0 comments Download
A tests/language/no_such_method_error_message_vm_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 4 months ago (2013-07-29 11:37:36 UTC) #1
ahe
LGTM! Thank you.
7 years, 4 months ago (2013-07-29 11:50:47 UTC) #2
Florian Schneider
7 years, 4 months ago (2013-07-29 13:44:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698