Issue 21015007: Fix sample_extension_test on 64-bit macos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21015007: Fix sample_extension_test on 64-bit macos. (Closed)

Created:
7 years, 4 months ago by Bill Hesse

Modified:
7 years, 4 months ago

Reviewers:
zra, Søren Gjesse, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix sample_extension_test on 64-bit macos. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=25620

Patch Set 2 : Fix ARM compilation as well #

Patch Set 3 : Add fix for android compilation. #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
M	runtime/bin/secure_socket_unsupported.cc	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	samples/sample_extension/sample_extension.gyp	View	1	1 chunk	+13 lines, -0 lines	1 comment	Download
M	samples/tests/samples/samples.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Committed patchset #3 manually as r25620 (presubmit successful).

7 years, 4 months ago (2013-07-30 16:03:03 UTC) #4

zra

https://codereview.chromium.org/21015007/diff/8001/samples/sample_extension/sample_extension.gyp File samples/sample_extension/sample_extension.gyp (right): https://codereview.chromium.org/21015007/diff/8001/samples/sample_extension/sample_extension.gyp#newcode14 samples/sample_extension/sample_extension.gyp:14: 'ldflags!': ['-static'], Maybe add a TODO to remove this ...

7 years, 4 months ago (2013-07-30 16:07:13 UTC) #5

Message was sent while issue was closed.

lgtm