Optimize equuality operation for two Boolean arguments.

Optimize equuality operation for two Boolean arguments.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25636

[Cutch, 2013-07-29 20:32:16]

lgtm

[srdjan, 2013-07-29 20:43:52]

As you suggested off-line, we could generalize that for classes that do not
override Object's equality.
Also type check for right argument is not needed in that case.
Will do that an resend the CL for review

[srdjan, 2013-07-30 20:16:17]

PTAL

[Cutch, 2013-07-30 20:22:30]

lgtm

https://codereview.chromium.org/21013005/diff/18001/runtime/vm/flow_graph_opt...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/21013005/diff/18001/runtime/vm/flow_graph_opt...
runtime/vm/flow_graph_optimizer.cc:2911: Token::Kind strict_kind =
(compare->kind() == Token::kEQ) ?
Maybe add:

ASSERT((compare->kind() == Token::kEQ) || (compare->kind() == Token::kNE));

[srdjan, 2013-07-30 20:26:50]

https://codereview.chromium.org/21013005/diff/18001/runtime/vm/flow_graph_opt...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/21013005/diff/18001/runtime/vm/flow_graph_opt...
runtime/vm/flow_graph_optimizer.cc:2911: Token::Kind strict_kind =
(compare->kind() == Token::kEQ) ?
On 2013/07/30 20:22:30, Cutch wrote:
> Maybe add:
> 
> ASSERT((compare->kind() == Token::kEQ) || (compare->kind() == Token::kNE));

Done.

[srdjan, 2013-07-30 20:44:30]

Committed patchset #6 manually as r25636 (presubmit successful).