Issue 21013004: Remove support for getters with parameters.

Issue 21013004: Remove support for getters with parameters. (Closed)

Created:
7 years, 4 months ago by Johnni Winther

Modified:
7 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove support for getters with parameters. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=25857

Patch Set 3 : Updated cf. comments. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -16 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	3 chunks	+3 lines, -13 lines	0 comments	Download
M	tests/compiler/dart2js/deprecated_features_test.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/getter_parameters_test.dart	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/21013004/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/21013004/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3865 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3865: trace('$element'); Remove trace. https://codereview.chromium.org/21013004/diff/1/tests/language/getter_parameters_test.dart File tests/language/getter_parameters_test.dart (right): https://codereview.chromium.org/21013004/diff/1/tests/language/getter_parameters_test.dart#newcode8 ...

7 years, 4 months ago (2013-08-06 14:25:06 UTC) #2

Johnni Winther

https://codereview.chromium.org/21013004/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/21013004/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode3865 sdk/lib/_internal/compiler/implementation/resolution/members.dart:3865: trace('$element'); On 2013/08/06 14:25:06, ahe wrote: > Remove trace. ...

7 years, 4 months ago (2013-08-07 06:35:17 UTC) #3

Johnni Winther

7 years, 4 months ago (2013-08-07 06:36:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r25857 (presubmit successful).

Expand Messages | Collapse Messages