Issue 21010005: Ensure FunctionTypeMirrors have a proper reflectee and implement ClassMirror.superinterfaces with i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21010005: Ensure FunctionTypeMirrors have a proper reflectee and implement ClassMirror.superinterfaces with i… (Closed)

Created:
7 years, 4 months ago by rmacnak

Modified:
7 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, ahe, Michael Lippautz (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Ensure FunctionTypeMirrors have a proper reflectee and implement ClassMirror.superinterfaces with internal code. Remove some unnecessary fields and constructor arguments.

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -73 lines)			Patch
M	runtime/lib/mirrors.cc	View	5 chunks	+15 lines, -39 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	9 chunks	+17 lines, -34 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rmacnak

On 2013/07/30 00:02:07, siva wrote: > lgtm gcl failure. Committed as r25599.

7 years, 4 months ago (2013-07-30 00:37:41 UTC) #3

rmacnak

7 years, 4 months ago (2013-07-30 16:26:43 UTC) #5

Message was sent while issue was closed.

On 2013/07/30 09:25:24, ahe wrote:
> How is this tested?

vm/dart/isolate_mirror_local_test

Hm, we need a cross-impl test.

Expand Messages | Collapse Messages