Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 21004014: Fix cancelable_future again. (Closed)

Created:
7 years, 4 months ago by nweiz
Modified:
7 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More library tags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M pkg/barback/lib/src/cancelable_future.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/barback/test/transformer/bad.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/barback/test/transformer/check_content.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/barback/test/transformer/create_asset.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/barback/test/transformer/many_to_one.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/barback/test/transformer/mock.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/barback/test/transformer/one_to_many.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/barback/test/transformer/rewrite.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 4 months ago (2013-07-31 00:33:47 UTC) #1
Bob Nystrom
LGTM.
7 years, 4 months ago (2013-07-31 00:35:06 UTC) #2
Bob Nystrom
LGTM.
7 years, 4 months ago (2013-07-31 00:37:43 UTC) #3
nweiz
7 years, 4 months ago (2013-07-31 00:38:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25654 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698