Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 21004011: Implements the two argument shuffle SIMD instruction for ARM. (Closed)

Created:
7 years, 4 months ago by zra
Modified:
7 years, 4 months ago
Reviewers:
regis, Cutch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implements the two argument shuffle SIMD instruction for ARM. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25638

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -8 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +42 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/lib/typed_data/float32x4_two_arg_shuffle_test.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 4 months ago (2013-07-30 20:22:44 UTC) #1
regis
LGTM
7 years, 4 months ago (2013-07-30 20:33:05 UTC) #2
zra
7 years, 4 months ago (2013-07-30 20:49:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25638 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698