Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 2100013005: Linter `0.1.21` (Closed)

Created:
4 years, 5 months ago by pquitslund
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Linter `0.1.21` * New `only_throw_errors` lint. * New lint to check for `empty_statements` (#259). * Fixed NSME when file contents cannot be read (#260). * Fixed unsafe cast in `iterable_contains_unrelated_type` (#267). R=alexeidiaz@google.com, brianwilkerson@google.com Committed: https://github.com/dart-lang/linter/commit/7ca3aab6ca45b988440e425c187993a533fbe27e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -214 lines) Patch
M CHANGELOG.md View 1 chunk +7 lines, -0 lines 0 comments Download
M lib/src/rules.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D lib/src/rules/only_throw_error.dart View 1 chunk +0 lines, -84 lines 0 comments Download
A + lib/src/rules/only_throw_errors.dart View 3 chunks +27 lines, -24 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
D test/_data/only_throw_error/only_throw_error.dart View 1 chunk +0 lines, -73 lines 0 comments Download
A + test/_data/only_throw_errors/only_throw_errors.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/integration_test.dart View 3 chunks +23 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
4 years, 5 months ago (2016-06-27 18:57:29 UTC) #2
pquitslund
Note that I also did a quick rename to remain consistent with preexisting lints (error=>errors).
4 years, 5 months ago (2016-06-27 18:58:37 UTC) #3
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-06-27 19:41:53 UTC) #4
Alexei Diaz
lgtm
4 years, 5 months ago (2016-06-27 20:00:05 UTC) #5
pquitslund
4 years, 5 months ago (2016-06-27 20:16:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ca3aab6ca45b988440e425c187993a533fbe27e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698