Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2099553002: Add an option to run skipped tests. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Dev version #

Patch Set 3 : Changelog entry #

Patch Set 4 : Fix bugs. #

Total comments: 2

Patch Set 5 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -73 lines) Patch
M CHANGELOG.md View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M doc/configuration.md View 2 chunks +16 lines, -0 lines 0 comments Download
M lib/src/backend/declarer.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M lib/src/runner.dart View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M lib/src/runner/configuration.dart View 8 chunks +11 lines, -0 lines 0 comments Download
M lib/src/runner/configuration/args.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M lib/src/runner/configuration/load.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M lib/src/runner/engine.dart View 1 2 3 8 chunks +32 lines, -30 lines 0 comments Download
M lib/src/runner/loader.dart View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M lib/src/runner/reporter/json.dart View 1 2 3 3 chunks +13 lines, -6 lines 0 comments Download
M test/runner/compact_reporter_test.dart View 1 2 3 3 chunks +23 lines, -5 lines 0 comments Download
M test/runner/configuration/configuration_test.dart View 8 chunks +8 lines, -0 lines 0 comments Download
M test/runner/configuration/top_level_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M test/runner/engine_test.dart View 1 2 3 3 chunks +70 lines, -0 lines 0 comments Download
M test/runner/expanded_reporter_test.dart View 1 2 3 3 chunks +17 lines, -4 lines 0 comments Download
M test/runner/json_reporter_test.dart View 1 2 3 2 chunks +29 lines, -4 lines 0 comments Download
M test/runner/runner_test.dart View 1 2 3 2 chunks +24 lines, -12 lines 0 comments Download
M test/utils.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
nweiz
4 years, 6 months ago (2016-06-23 23:53:56 UTC) #1
kevmoo
This CL breaks the creation of Engine in lib/test.dart @ line 60 otherwise, LGTM
4 years, 5 months ago (2016-06-27 18:18:27 UTC) #2
nweiz
PTAL I found a few additional bugs, which required some refactoring.
4 years, 5 months ago (2016-07-06 21:10:45 UTC) #3
kevmoo
still LGTM https://codereview.chromium.org/2099553002/diff/60001/test/utils.dart File test/utils.dart (right): https://codereview.chromium.org/2099553002/diff/60001/test/utils.dart#newcode17 test/utils.dart:17: import 'package:test/src/runner/configuration.dart'; now unused?
4 years, 5 months ago (2016-07-06 21:34:27 UTC) #4
nweiz
Code review changes
4 years, 5 months ago (2016-07-06 21:36:02 UTC) #5
nweiz
https://codereview.chromium.org/2099553002/diff/60001/test/utils.dart File test/utils.dart (right): https://codereview.chromium.org/2099553002/diff/60001/test/utils.dart#newcode17 test/utils.dart:17: import 'package:test/src/runner/configuration.dart'; On 2016/07/06 21:34:27, kevmoo wrote: > now ...
4 years, 5 months ago (2016-07-06 21:36:08 UTC) #6
nweiz
4 years, 5 months ago (2016-07-06 21:37:55 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
091cadbf0bdb6daf37cff1774723980714600552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698