Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 209563002: pkg/docgen: the big refactor (Closed)

Created:
6 years, 9 months ago by kevmoo
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/docgen: the big refactor Separated code into mini-libraries Eliminated "static" classes in favor of named imports R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=34313

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : long lines #

Patch Set 4 : silly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2282 lines, -2299 lines) Patch
M pkg/docgen/bin/docgen.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/lib/docgen.dart View 1 2 chunks +15 lines, -2123 lines 0 comments Download
A pkg/docgen/lib/src/generator.dart View 1 2 1 chunk +492 lines, -0 lines 0 comments Download
A pkg/docgen/lib/src/library_helpers.dart View 1 chunk +233 lines, -0 lines 0 comments Download
A + pkg/docgen/lib/src/model_helpers.dart View 3 chunks +51 lines, -60 lines 0 comments Download
M pkg/docgen/lib/src/models.dart View 2 chunks +1184 lines, -3 lines 0 comments Download
A pkg/docgen/lib/src/package_helpers.dart View 1 chunk +84 lines, -0 lines 0 comments Download
D pkg/docgen/lib/src/utils.dart View 1 chunk +0 lines, -107 lines 0 comments Download
A pkg/docgen/lib/src/viewer.dart View 1 2 1 chunk +201 lines, -0 lines 0 comments Download
M pkg/docgen/test/multi_library_code/lib/dottedLibraryName.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/docgen/test/multi_library_code/lib/test_lib.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/docgen/test/multi_library_code/lib/test_lib_bar.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/docgen/test/multi_library_code/lib/test_lib_foo.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/docgen/test/multi_library_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/docgen/test/single_library_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
This is a BIG CL. Keep in mind: 1) This contains ZERO algorithm changes. Just ...
6 years, 9 months ago (2014-03-23 18:15:22 UTC) #1
Emily Fortuna
bravo on a heroic code refactor. lgtm
6 years, 9 months ago (2014-03-24 16:38:17 UTC) #2
kevmoo
Committed patchset #4 manually as r34313 (presubmit successful).
6 years, 9 months ago (2014-03-24 16:46:26 UTC) #3
Alan Knight
6 years, 9 months ago (2014-03-24 17:37:04 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698