Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2094533003: Fix coded buffer reader so all tests pass using dart2js. (Closed)

Created:
4 years, 6 months ago by skybrian
Modified:
4 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart-protobuf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/protobuf/coded_buffer_reader.dart View 5 chunks +18 lines, -16 lines 0 comments Download
M test/codec_test.dart View 2 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
skybrian
4 years, 6 months ago (2016-06-22 22:46:53 UTC) #2
Søren Gjesse
lgtm
4 years, 6 months ago (2016-06-23 09:08:41 UTC) #3
skybrian
4 years, 5 months ago (2016-06-27 16:39:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ab6e520c2a73fd13d7483211086c2404b941482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698