Issue 209333003: pkg/mock - NEW!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209333003: pkg/mock - NEW! (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/mock - NEW! Pulled out of unittest. Using new 'matcher' package BUG= https://code.google.com/p/dart/issues/detail?id=16990 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34323

Patch Set 2 : nit #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -42 lines)			Patch
A +	pkg/mock/LICENSE	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/mock/lib/mock.dart	View	1	2 chunks	+2 lines, -21 lines	0 comments	Download
A	pkg/mock/pubspec.yaml	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A +	pkg/mock/test/mock_regexp_negative_test.dart	View		1 chunk	+6 lines, -4 lines	0 comments	Download
A +	pkg/mock/test/mock_stepwise_negative_test.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
A +	pkg/mock/test/mock_test.dart	View		3 chunks	+17 lines, -16 lines	0 comments	Download
M	pkg/pkg.status	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm! https://codereview.chromium.org/209333003/diff/1/pkg/mock/lib/mock.dart File pkg/mock/lib/mock.dart (right): https://codereview.chromium.org/209333003/diff/1/pkg/mock/lib/mock.dart#newcode8 pkg/mock/lib/mock.dart:8: * ## Using ## nit: probably remove this ...

6 years, 9 months ago (2014-03-24 19:09:57 UTC) #2

kevmoo

https://codereview.chromium.org/209333003/diff/1/pkg/mock/lib/mock.dart File pkg/mock/lib/mock.dart (right): https://codereview.chromium.org/209333003/diff/1/pkg/mock/lib/mock.dart#newcode8 pkg/mock/lib/mock.dart:8: * ## Using ## On 2014/03/24 19:09:57, Siggi Cherem ...

6 years, 9 months ago (2014-03-24 19:21:56 UTC) #3

kevmoo

6 years, 9 months ago (2014-03-24 19:22:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34323 (presubmit successful).

Expand Messages | Collapse Messages

Issue 209333003: pkg/mock - NEW! (Closed)

Description

Patch Set 1 #

Patch Set 2 : nit #

Messages