Issue 209233005: Simplify content rewriting.

Issue 209233005: Simplify content rewriting. (Closed)

Created:
6 years, 9 months ago by ahe

Modified:
6 years, 9 months ago

Reviewers:
lukechurch, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Simplify content rewriting. BUG=http://code.google.com/p/dart/issues/detail?id=17726 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=34415

Patch Set 2 : Merged with r34414 #

Patch Set 3 : Address Kasper's comments. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -61 lines)			Patch
M	dart/site/try/src/decoration.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	dart/site/try/src/html_to_text.dart	View	1 2	1 chunk	+72 lines, -0 lines	0 comments	Download
M	dart/site/try/src/interaction_manager.dart	View		2 chunks	+12 lines, -56 lines	0 comments	Download
M	dart/tests/try/paste_content_rewriting_test.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	dart/tests/try/try.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/209233005/diff/1/dart/site/try/src/html_to_text.dart File dart/site/try/src/html_to_text.dart (right): https://codereview.chromium.org/209233005/diff/1/dart/site/try/src/html_to_text.dart#newcode8 dart/site/try/src/html_to_text.dart:8: max; So you use show on the (small) ...

6 years, 9 months ago (2014-03-25 14:41:21 UTC) #2

ahe

Thank you, Kasper! https://codereview.chromium.org/209233005/diff/1/dart/site/try/src/html_to_text.dart File dart/site/try/src/html_to_text.dart (right): https://codereview.chromium.org/209233005/diff/1/dart/site/try/src/html_to_text.dart#newcode8 dart/site/try/src/html_to_text.dart:8: max; On 2014/03/25 14:41:22, kasperl wrote: ...

6 years, 9 months ago (2014-03-26 10:02:12 UTC) #3

ahe

6 years, 9 months ago (2014-03-26 10:03:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r34415 (presubmit successful).

Expand Messages | Collapse Messages