Issue 209123003: Revert r34269, as it broke the editor build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209123003: Revert r34269, as it broke the editor build (Closed)

Created:
6 years, 9 months ago by dgrove

Modified:
6 years, 9 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, keertip

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert r34269, as it broke the editor build (e.g., http://chromegw.corp.google.com/i/client.dart/builders/dart-editor-mac-be/builds/5521/steps/run_tests/logs/stdio ) Committed: https://code.google.com/p/dart/source/detail?r=34274

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+419 lines, -664 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/barback_server.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart	View	1 chunk	+0 lines, -444 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart	View	10 chunks	+204 lines, -48 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/utils.dart	View	2 chunks	+31 lines, -81 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/bad_commands_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/error_responds_with_id_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_errors_test.dart	View	3 chunks	+29 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_multiple_test.dart	View	1 chunk	+18 lines, -12 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_responds_with_id_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_test.dart	View	1 chunk	+39 lines, -36 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_with_line_test.dart	View	1 chunk	+9 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_already_served_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart	View	2 chunks	+34 lines, -12 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_responds_with_id_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_arg_errors_test.dart	View	2 chunks	+34 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_not_served_test.dart	View	1 chunk	+7 lines, -2 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_responds_with_id_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_subdirectory_still_watched_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_superdirectory_still_watched_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_errors_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_responds_with_id_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_with_line_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dgrove

6 years, 9 months ago (2014-03-21 22:14:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r34274 (presubmit successful).

Expand Messages | Collapse Messages