Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 209093002: Make all objects print at least their type in PrintToJSONStream. (Closed)

Created:
6 years, 9 months ago by koda
Modified:
6 years, 9 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make all objects print at least their type in PrintToJSONStream. Also check this in the unit test. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=34315

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M runtime/vm/object.cc View 19 chunks +19 lines, -19 lines 0 comments Download
M runtime/vm/object_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 9 months ago (2014-03-21 22:05:05 UTC) #1
turnidge
lgtm
6 years, 9 months ago (2014-03-23 22:51:08 UTC) #2
koda
6 years, 9 months ago (2014-03-24 16:57:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698