Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 20908002: Fix readLineSync to work in checked mode. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix readLineSync to work in checked mode. Also update the test to run in checked mode. BUG=https://code.google.com/p/dart/issues/detail?id=12058 R=sgjesse@google.com, whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/io/stdio.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/stdin_sync_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 5 months ago (2013-07-27 11:30:24 UTC) #1
Søren Gjesse
lgtm
7 years, 4 months ago (2013-07-29 06:43:18 UTC) #2
Bill Hesse
lgtm
7 years, 4 months ago (2013-07-29 08:13:54 UTC) #3
Anders Johnsen
7 years, 4 months ago (2013-07-29 09:54:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r25552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698