Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2257)

Issue 209003005: utility for manually running all analysis_server tests (Closed)

Created:
6 years, 9 months ago by danrubel
Modified:
6 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

utility for manually running all analysis_server tests BUG= R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=34522

Patch Set 1 #

Total comments: 8

Patch Set 2 : address comments #

Patch Set 3 : split change into separate cl #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M pkg/analysis_server/test/analysis_server_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/test/test_all.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danrubel
6 years, 9 months ago (2014-03-22 04:03:39 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/209003005/diff/1/pkg/analysis_server/test/channel_test.dart File pkg/analysis_server/test/channel_test.dart (right): https://codereview.chromium.org/209003005/diff/1/pkg/analysis_server/test/channel_test.dart#newcode16 pkg/analysis_server/test/channel_test.dart:16: main(List<String> args) { I'm not sure what the value ...
6 years, 9 months ago (2014-03-22 14:37:20 UTC) #2
danrubel
https://codereview.chromium.org/209003005/diff/1/pkg/analysis_server/test/channel_test.dart File pkg/analysis_server/test/channel_test.dart (right): https://codereview.chromium.org/209003005/diff/1/pkg/analysis_server/test/channel_test.dart#newcode16 pkg/analysis_server/test/channel_test.dart:16: main(List<String> args) { On 2014/03/22 14:37:20, Brian Wilkerson wrote: ...
6 years, 9 months ago (2014-03-25 19:03:58 UTC) #3
Brian Wilkerson
Sorry about the delay! LGTM
6 years, 8 months ago (2014-03-28 17:53:00 UTC) #4
danrubel
6 years, 8 months ago (2014-03-28 20:29:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r34522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698