Issue 208823005: pkg/matcher

Issue 208823005: pkg/matcher (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/matcher Copied from unittest. Unittest will update to use this package once it has been published. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34282

Patch Set 2 : nit #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -225 lines)			Patch
A +	pkg/matcher/LICENSE	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/matcher/lib/matcher.dart	View	1	1 chunk	+11 lines, -16 lines	0 comments	Download
A +	pkg/matcher/lib/mirror_matchers.dart	View		1 chunk	+4 lines, -23 lines	0 comments	Download
A +	pkg/matcher/lib/src/core_matchers.dart	View		3 chunks	+5 lines, -7 lines	0 comments	Download
A +	pkg/matcher/lib/src/description.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
A +	pkg/matcher/lib/src/expect.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	pkg/matcher/lib/src/future_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/matcher/lib/src/interfaces.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/matcher/lib/src/iterable_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/matcher/lib/src/map_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/matcher/lib/src/numeric_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/matcher/lib/src/operator_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/matcher/lib/src/pretty_print.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
A +	pkg/matcher/lib/src/string_matchers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/matcher/lib/src/utils.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	pkg/matcher/pubspec.yaml	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A +	pkg/matcher/test/matchers_minified_test.dart	View		11 chunks	+15 lines, -14 lines	0 comments	Download
A +	pkg/matcher/test/matchers_test.dart	View		52 chunks	+84 lines, -83 lines	0 comments	Download
A +	pkg/matcher/test/matchers_unminified_test.dart	View		11 chunks	+15 lines, -14 lines	0 comments	Download
A +	pkg/matcher/test/mirror_matchers_test.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	pkg/matcher/test/pretty_print_minified_test.dart	View		2 chunks	+11 lines, -9 lines	0 comments	Download
A +	pkg/matcher/test/pretty_print_test.dart	View		10 chunks	+31 lines, -29 lines	0 comments	Download
A +	pkg/matcher/test/pretty_print_unminified_test.dart	View		2 chunks	+10 lines, -9 lines	0 comments	Download
A +	pkg/matcher/test/test_common.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/matcher/test/test_utils.dart	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/pkg.status	View		4 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

Required before we move mock out of unittest - https://code.google.com/p/dart/issues/detail?id=16990

6 years, 9 months ago (2014-03-21 22:31:10 UTC) #1

blois

https://codereview.chromium.org/208823005/diff/1/pkg/matcher/lib/matcher.dart File pkg/matcher/lib/matcher.dart (right): https://codereview.chromium.org/208823005/diff/1/pkg/matcher/lib/matcher.dart#newcode19 pkg/matcher/lib/matcher.dart:19: import 'src/interfaces.dart'; alphabetical https://codereview.chromium.org/208823005/diff/1/pkg/matcher/test/pretty_print_minified_test.dart File pkg/matcher/test/pretty_print_minified_test.dart (right): https://codereview.chromium.org/208823005/diff/1/pkg/matcher/test/pretty_print_minified_test.dart#newcode35 pkg/matcher/test/pretty_print_minified_test.dart:35: ...

6 years, 9 months ago (2014-03-21 23:04:29 UTC) #2

kevmoo

PTAL https://codereview.chromium.org/208823005/diff/1/pkg/matcher/lib/matcher.dart File pkg/matcher/lib/matcher.dart (right): https://codereview.chromium.org/208823005/diff/1/pkg/matcher/lib/matcher.dart#newcode19 pkg/matcher/lib/matcher.dart:19: import 'src/interfaces.dart'; On 2014/03/21 23:04:30, blois wrote: > ...

6 years, 9 months ago (2014-03-21 23:14:31 UTC) #3

kevmoo

6 years, 9 months ago (2014-03-21 23:50:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r34282 (presubmit successful).

Expand Messages | Collapse Messages