Issue 208703003: Use the right name for the OldWebSocketApi constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208703003: Use the right name for the OldWebSocketApi constructor. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use the right name for the OldWebSocketApi constructor. Also get rid of some unused imports. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34277

Patch Set 1 #

Patch Set 2 : roll forward web socket change #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+236 lines, -871 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/barback_server.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/base_server.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
A +	sdk/lib/_internal/pub/lib/src/barback/old_web_socket_api.dart	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart	View	1	10 chunks	+48 lines, -209 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/utils.dart	View	1	2 chunks	+82 lines, -32 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/bad_commands_test.dart	View	1	1 chunk	+0 lines, -45 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/error_responds_with_id_test.dart	View	1	1 chunk	+0 lines, -31 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_errors_test.dart	View	1	3 chunks	+11 lines, -29 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_multiple_test.dart	View	1	1 chunk	+13 lines, -19 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_responds_with_id_test.dart	View	1	1 chunk	+0 lines, -34 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_test.dart	View	1	1 chunk	+36 lines, -39 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/path_to_urls_with_line_test.dart	View	1	1 chunk	+6 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_already_served_test.dart	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_arg_errors_test.dart	View	1	2 chunks	+12 lines, -34 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_responds_with_id_test.dart	View	1	1 chunk	+0 lines, -35 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/serve_directory_test.dart	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_arg_errors_test.dart	View	1	2 chunks	+12 lines, -34 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_not_served_test.dart	View	1	1 chunk	+2 lines, -7 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_responds_with_id_test.dart	View	1	1 chunk	+0 lines, -32 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_subdirectory_still_watched_test.dart	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_superdirectory_still_watched_test.dart	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/unserve_directory_test.dart	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_errors_test.dart	View	1	1 chunk	+0 lines, -77 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_responds_with_id_test.dart	View	1	1 chunk	+0 lines, -32 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_test.dart	View	1	1 chunk	+0 lines, -101 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_with_line_test.dart	View	1	1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 9 months ago (2014-03-21 22:31:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r34277 (presubmit successful).

Expand Messages | Collapse Messages