Issue 208653012: Only return eventhandler tokens in stacks of 8, to avoid runtime calls.

Issue 208653012: Only return eventhandler tokens in stacks of 8, to avoid runtime calls. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only return eventhandler tokens in stacks of 8, to avoid runtime calls. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34359

Patch Set 2 : Review fixes. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -14 lines)			Patch
M	runtime/bin/eventhandler_android.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler_android.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/bin/eventhandler_linux.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler_linux.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/bin/eventhandler_macos.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View	1	3 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm, with comments https://codereview.chromium.org/208653012/diff/1/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/208653012/diff/1/runtime/bin/socket_patch.dart#newcode358 runtime/bin/socket_patch.dart:358: static const int RETURN_TOKEN_COMMAND = 11; ...

6 years, 9 months ago (2014-03-25 13:31:21 UTC) #2

Anders Johnsen

https://codereview.chromium.org/208653012/diff/1/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/208653012/diff/1/runtime/bin/socket_patch.dart#newcode358 runtime/bin/socket_patch.dart:358: static const int RETURN_TOKEN_COMMAND = 11; On 2014/03/25 13:31:22, ...

6 years, 9 months ago (2014-03-25 13:43:35 UTC) #3

Anders Johnsen

6 years, 9 months ago (2014-03-25 13:44:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34359 (presubmit successful).

Expand Messages | Collapse Messages