Issue 208623008: Include exports in resolver.libraries

Issue 208623008: Include exports in resolver.libraries (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 9 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Include exports in resolver.libraries R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34275

Patch Set 3 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
	M	pkg/code_transformers/lib/src/resolver_impl.dart	View	1 2	3 chunks	+18 lines, -2 lines	0 comments	Download
	M	pkg/code_transformers/test/resolver_test.dart	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://codereview.chromium.org/208623008/diff/20001/pkg/code_transformers/lib/src/resolver_impl.dart File pkg/code_transformers/lib/src/resolver_impl.dart (right): https://codereview.chromium.org/208623008/diff/20001/pkg/code_transformers/lib/src/resolver_impl.dart#newcode174 pkg/code_transformers/lib/src/resolver_impl.dart:174: lib.imports.map((i) => i.importedLibrary).forEach(_collectLibraries); use importedLibraries rather than imports? ...

6 years, 9 months ago (2014-03-21 22:13:20 UTC) #2

Siggi Cherem (dart-lang)

thanks! https://codereview.chromium.org/208623008/diff/20001/pkg/code_transformers/lib/src/resolver_impl.dart File pkg/code_transformers/lib/src/resolver_impl.dart (right): https://codereview.chromium.org/208623008/diff/20001/pkg/code_transformers/lib/src/resolver_impl.dart#newcode174 pkg/code_transformers/lib/src/resolver_impl.dart:174: lib.imports.map((i) => i.importedLibrary).forEach(_collectLibraries); On 2014/03/21 22:13:21, blois wrote: ...

6 years, 9 months ago (2014-03-21 22:21:10 UTC) #3

Siggi Cherem (dart-lang)

6 years, 9 months ago (2014-03-21 22:21:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r34275 (presubmit successful).

Expand Messages | Collapse Messages