Issue 208593004: pkg/unittest: dartfmt

Issue 208593004: pkg/unittest: dartfmt (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: dartfmt R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34268

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -69 lines)			Patch
M	pkg/unittest/lib/html_individual_config.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/lib/src/core_matchers.dart	View	24 chunks	+36 lines, -54 lines	2 comments	Download
M	pkg/unittest/lib/src/interfaces.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/unittest/lib/src/iterable_matchers.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	pkg/unittest/lib/src/operator_matchers.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/unittest/lib/src/simple_configuration.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/unittest.dart	View	3 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm. thanks! https://codereview.chromium.org/208593004/diff/1/pkg/unittest/lib/src/core_matchers.dart File pkg/unittest/lib/src/core_matchers.dart (left): https://codereview.chromium.org/208593004/diff/1/pkg/unittest/lib/src/core_matchers.dart#oldcode712 pkg/unittest/lib/src/core_matchers.dart:712: const _HasLength([Matcher matcher = null]) : this._matcher ...

6 years, 9 months ago (2014-03-21 20:00:45 UTC) #2

kevmoo

Committed patchset #1 manually as r34268 (presubmit successful).

6 years, 9 months ago (2014-03-21 20:12:52 UTC) #3

kevmoo

6 years, 9 months ago (2014-03-21 20:13:02 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/208593004/diff/1/pkg/unittest/lib/src/core_ma...
File pkg/unittest/lib/src/core_matchers.dart (left):

https://codereview.chromium.org/208593004/diff/1/pkg/unittest/lib/src/core_ma...
pkg/unittest/lib/src/core_matchers.dart:712: const _HasLength([Matcher matcher =
null]) : this._matcher = matcher;
On 2014/03/21 20:00:45, Siggi Cherem (dart-lang) wrote:
> btw - I'm not sure I agree with this one, I filed: dartbug.com/17642

Good to have the bug. Being consistent is the most important bit.

Expand Messages | Collapse Messages