Issue 20847003: Fix Dromaeo performance tests.

Issue 20847003: Fix Dromaeo performance tests. (Closed)

Created:
7 years, 5 months ago by Emily Fortuna

Modified:
7 years, 5 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Dromaeo performance tests. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=25544

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	samples/third_party/dromaeo/tests/dom-modify-html.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	samples/third_party/dromaeo/tests/dom-traverse-html.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/testing/perf_testing/run_perf_tests.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/20847003/diff/1/samples/third_party/dromaeo/tests/dom-modify-html.dart File samples/third_party/dromaeo/tests/dom-modify-html.dart (right): https://codereview.chromium.org/20847003/diff/1/samples/third_party/dromaeo/tests/dom-modify-html.dart#newcode68 samples/third_party/dromaeo/tests/dom-modify-html.dart:68: document.body.insertBefore(elems[i], document.body.firstChild); Is this API supposed to be ...

7 years, 5 months ago (2013-07-26 23:22:15 UTC) #2

Emily Fortuna

https://codereview.chromium.org/20847003/diff/1/samples/third_party/dromaeo/tests/dom-modify-html.dart File samples/third_party/dromaeo/tests/dom-modify-html.dart (right): https://codereview.chromium.org/20847003/diff/1/samples/third_party/dromaeo/tests/dom-modify-html.dart#newcode68 samples/third_party/dromaeo/tests/dom-modify-html.dart:68: document.body.insertBefore(elems[i], document.body.firstChild); On 2013/07/26 23:22:15, vsm wrote: > Is ...

7 years, 5 months ago (2013-07-26 23:30:21 UTC) #3

Emily Fortuna

7 years, 5 months ago (2013-07-26 23:31:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r25544 (presubmit successful).

Expand Messages | Collapse Messages