Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208443002: Use a bit in the handle structure to indicate if it is a prologue weak handle instead of the taggin… (Closed)

Created:
6 years, 9 months ago by siva
Modified:
6 years, 9 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use a bit in the handle structure to indicate if it is a prologue weak handle instead of the tagging the address. R=koda@google.com Committed: https://code.google.com/p/dart/source/detail?r=34258

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -77 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 4 chunks +14 lines, -31 lines 0 comments Download
M runtime/vm/dart_api_state.h View 1 2 3 7 chunks +25 lines, -24 lines 0 comments Download
M runtime/vm/gc_marker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/handles.h View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/handles_impl.h View 2 chunks +5 lines, -7 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/scavenger.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
6 years, 9 months ago (2014-03-21 16:17:54 UTC) #1
koda
https://codereview.chromium.org/208443002/diff/40001/runtime/vm/dart_api_state.h File runtime/vm/dart_api_state.h (right): https://codereview.chromium.org/208443002/diff/40001/runtime/vm/dart_api_state.h#newcode260 runtime/vm/dart_api_state.h:260: kExternalSizeBitsSize = (kBitsPerWord - 1), Should be (kBitsPerWord - ...
6 years, 9 months ago (2014-03-21 16:26:38 UTC) #2
siva
https://codereview.chromium.org/208443002/diff/40001/runtime/vm/dart_api_state.h File runtime/vm/dart_api_state.h (right): https://codereview.chromium.org/208443002/diff/40001/runtime/vm/dart_api_state.h#newcode260 runtime/vm/dart_api_state.h:260: kExternalSizeBitsSize = (kBitsPerWord - 1), Good catch. Yes will ...
6 years, 9 months ago (2014-03-21 16:48:20 UTC) #3
koda
lgtm
6 years, 9 months ago (2014-03-21 17:03:11 UTC) #4
siva
6 years, 9 months ago (2014-03-21 17:23:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r34258 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698