Issue 208333015: Don't add ':443' to host header, when the connection is secure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208333015: Don't add ':443' to host header, when the connection is secure. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't add ':443' to host header, when the connection is https. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34293

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	sdk/lib/io/http_headers.dart	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
	M	sdk/lib/io/http_impl.dart	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/208333015/diff/1/sdk/lib/io/http_headers.dart File sdk/lib/io/http_headers.dart (right): https://codereview.chromium.org/208333015/diff/1/sdk/lib/io/http_headers.dart#newcode23 sdk/lib/io/http_headers.dart:23: {int defaultPort: HttpClient.DEFAULT_HTTP_PORT}) defaultPort -> defaultPortForScheme

6 years, 9 months ago (2014-03-24 07:58:24 UTC) #2

Anders Johnsen

https://codereview.chromium.org/208333015/diff/1/sdk/lib/io/http_headers.dart File sdk/lib/io/http_headers.dart (right): https://codereview.chromium.org/208333015/diff/1/sdk/lib/io/http_headers.dart#newcode23 sdk/lib/io/http_headers.dart:23: {int defaultPort: HttpClient.DEFAULT_HTTP_PORT}) On 2014/03/24 07:58:24, Søren Gjesse wrote: ...

6 years, 9 months ago (2014-03-24 08:01:57 UTC) #3

Anders Johnsen

6 years, 9 months ago (2014-03-24 08:10:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34293 (presubmit successful).

Expand Messages | Collapse Messages

Issue 208333015: Don't add ':443' to host header, when the connection is secure. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages