Clarify that dart system libs have lower priority regardless how imported.

Clarify that dart system libs have lower priority regardless how imported.

R=johnniwinther@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34378

[gbracha, 2014-03-21 17:47:38]

Fix for bug 17678

[kasperl, 2014-03-24 07:48:13]

Adding Johnni as a reviewer per local discussions.

https://codereview.chromium.org/208293006/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/208293006/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:5034: A {\em system library} is a library whose
URI begins with \code{dart:}. Any other library is {\em non-system library}. If
a name $N$ is referenced by a library $L$ and $N$ would be introduced into the
top level scope of $L$ by an import of a  system library and an import of a
non-system library:
I don't think this is enough. We need to talk about the element that the name N
refers to. If the name would be introduced into the top-level scope of L by the
import of a library I1 and another library I2 and that the definition of N
pulled in via the import of I1 is (indirectly through potentially long re-export
chains) from a system library then we want to hide the name N on the import of
I1.

[gbracha, 2014-03-24 17:54:17]

On 2014/03/24 07:48:13, kasperl wrote:
> Adding Johnni as a reviewer per local discussions.
> 
>
https://codereview.chromium.org/208293006/diff/1/docs/language/dartLangSpec.tex
> File docs/language/dartLangSpec.tex (right):
> 
>
https://codereview.chromium.org/208293006/diff/1/docs/language/dartLangSpec.t...
> docs/language/dartLangSpec.tex:5034: A {\em system library} is a library whose
> URI begins with \code{dart:}. Any other library is {\em non-system library}.
If
> a name $N$ is referenced by a library $L$ and $N$ would be introduced into the
> top level scope of $L$ by an import of a  system library and an import of a
> non-system library:
> I don't think this is enough. We need to talk about the element that the name
N
> refers to. If the name would be introduced into the top-level scope of L by
the
> import of a library I1 and another library I2 and that the definition of N
> pulled in via the import of I1 is (indirectly through potentially long
re-export
> chains) from a system library then we want to hide the name N on the import of
> I1.

PTAL

[Johnni Winther, 2014-03-25 07:21:11]

LGTM

https://codereview.chromium.org/208293006/diff/40001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/208293006/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:5036: A {\em system library} is a library whose
URI begins with \code{dart:}. Any other library is a {\em non-system library}.
If a name $N$ is referenced by a library $L$ and $N$ would be introduced into
the top level scope of $L$ by
I don't think "whose URI" is clearly defined. It probably means something like a
library "that can be imported/exported through a URI beginning with 'dart:'".

https://codereview.chromium.org/208293006/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:5141: If a name $N$ is referenced by a library
$L$ and $N$ would be introduced into the exported namespace of $L$ by exports of
two libraries, $L_1$ and $L_2$, and the sported namespace of $L_1$ binds $N$ to
a declaration originating in a system library:
'sported' -> 'exported'.

[kasperl, 2014-03-25 07:29:46]

LGTM. Thanks, Gilad!

[gbracha, 2014-03-25 18:15:55]

Committed patchset #4 manually as r34378 (presubmit successful).

[gbracha, 2014-03-25 18:16:10]

https://codereview.chromium.org/208293006/diff/40001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/208293006/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:5036: A {\em system library} is a library whose
URI begins with \code{dart:}. Any other library is a {\em non-system library}.
If a name $N$ is referenced by a library $L$ and $N$ would be introduced into
the top level scope of $L$ by
On 2014/03/25 07:21:11, Johnni Winther wrote:
> I don't think "whose URI" is clearly defined. It probably means something like
a
> library "that can be imported/exported through a URI beginning with 'dart:'".

I've reorganized this so it is  cleaner and somewhat more precise.

https://codereview.chromium.org/208293006/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:5141: If a name $N$ is referenced by a library
$L$ and $N$ would be introduced into the exported namespace of $L$ by exports of
two libraries, $L_1$ and $L_2$, and the sported namespace of $L_1$ binds $N$ to
a declaration originating in a system library:
On 2014/03/25 07:21:11, Johnni Winther wrote:
> 'sported' -> 'exported'.

fixed