Issue 208243006: Allow built in Observatory to work on any port

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208243006: Allow built in Observatory to work on any port (Closed)

Created:
6 years, 9 months ago by Cutch

Modified:
6 years, 9 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow built in Observatory to work on any port https://code.google.com/p/dart/issues/detail?id=17537 R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=34267

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -31 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	11 chunks	+16 lines, -13 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	11 chunks	+16 lines, -13 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/service_html.dart	View	1 chunk	+16 lines, -4 lines	1 comment	Download
M	runtime/bin/vmservice/client/lib/src/app/application.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

lgtm https://codereview.chromium.org/208243006/diff/1/runtime/bin/vmservice/client/lib/service_html.dart File runtime/bin/vmservice/client/lib/service_html.dart (right): https://codereview.chromium.org/208243006/diff/1/runtime/bin/vmservice/client/lib/service_html.dart#newcode29 runtime/bin/vmservice/client/lib/service_html.dart:29: // want to connect on the defaul port. ...

6 years, 9 months ago (2014-03-21 19:48:44 UTC) #2

Cutch

6 years, 9 months ago (2014-03-21 20:06:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34267 (presubmit successful).

Expand Messages | Collapse Messages