Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 208193002: Revert "Add Isolate.kill()." (Closed)

Created:
6 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Add Isolate.kill()." Either ping or kill tests fail in some cases. Committed: https://code.google.com/p/dart/source/detail?r=34247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -331 lines) Patch
M sdk/lib/_internal/lib/isolate_helper.dart View 7 chunks +12 lines, -83 lines 0 comments Download
M sdk/lib/isolate/isolate.dart View 4 chunks +19 lines, -54 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -4 lines 0 comments Download
D tests/isolate/kill2_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/isolate/kill3_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/isolate/kill_self_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/isolate/kill_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
M tests/isolate/ping_pause_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/ping_test.dart View 2 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
6 years, 9 months ago (2014-03-21 13:20:31 UTC) #1
Lasse Reichstein Nielsen
TBR
6 years, 9 months ago (2014-03-21 13:20:41 UTC) #2
Lasse Reichstein Nielsen
6 years, 9 months ago (2014-03-21 13:21:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698