Rename [call$...] properties to [$...] in compiled code.

Rename [call$...] properties to [$...] in compiled code.

BUG=
R=floitsch@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34294
Reverted: https://code.google.com/p/dart/source/detail?r=34296

Committed: https://code.google.com/p/dart/source/detail?r=34301
Reverted: https://code.google.com/p/dart/source/detail?r=34309

Committed: https://code.google.com/p/dart/source/detail?r=34640

[herhut, 2014-03-21 13:33:59]

This simply renames call$<n> to just $<n> for closure invocations. We do not
currently minify those (due to dependencies in applyFunction).

[karlklose, 2014-03-21 13:58:13]

LGTM.

[herhut, 2014-03-24 09:07:05]

Committed patchset #3 manually as r34294 (presubmit successful).

[floitsch, 2014-03-24 09:18:16]

LGTM.

[herhut, 2014-03-24 11:27:48]

On 2014/03/24 09:18:16, floitsch wrote:
> LGTM.

Reverted in https://codereview.chromium.org/209383005/

[herhut, 2014-03-24 11:31:45]

The name 'call' was also hardcoded in js_mirrors.dart. This patch addresses
that.

[karlklose, 2014-03-24 11:57:10]

LGTM.

[floitsch, 2014-03-24 11:58:32]

LGTM.

https://codereview.chromium.org/208043003/diff/80001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/208043003/diff/80001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_mirrors.dart:2048: var extractCallName = JS('', r'''
You could incorporate the string:
String callPrefix = JS_GET_NAME("CALL_PREFIX");
var extractCallName = JS('', '''
function(reflectee) {
  if (# == property.substring(0, #) && 
      property[#] >= '0' &&
      property[#] <= '9') {
    return property;
  }
  return null;
}''', callPrefix, callPrefix.length, callPrefix.length);

[herhut, 2014-03-24 12:38:12]

Committed patchset #5 manually as r34301 (presubmit successful).

[herhut, 2014-04-02 07:59:59]

Another iteration of this patch. This time, I really hope I found all hardcoded
uses of "call".

[floitsch, 2014-04-02 08:06:16]

Still LGTM.

[karlklose, 2014-04-02 08:08:12]

On 2014/04/02 08:06:16, floitsch wrote:
> Still LGTM.

SLGTM.

[herhut, 2014-04-02 08:23:07]

Committed patchset #6 manually as r34640 (presubmit successful).