Issue 207853003: Don't try to infer that the current isolate is executing an event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207853003: Don't try to infer that the current isolate is executing an event. (Closed)

Created:
6 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't try to infer that the current isolate is executing an event. The inference didn't work in the browser. Instead keep an explicit bit set. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34244

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove debug print. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	sdk/lib/_internal/lib/isolate_helper.dart	View		4 chunks	+5 lines, -2 lines	0 comments	Download
	M	tests/isolate/ping_test.dart	View	1	2 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/207853003/diff/1/tests/isolate/ping_test.dart File tests/isolate/ping_test.dart (right): https://codereview.chromium.org/207853003/diff/1/tests/isolate/ping_test.dart#newcode29 tests/isolate/ping_test.dart:29: print(result); Debug print

6 years, 9 months ago (2014-03-21 10:43:40 UTC) #2

Lasse Reichstein Nielsen

6 years, 9 months ago (2014-03-21 10:59:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r34244 (presubmit successful).

Expand Messages | Collapse Messages