Issue 207823002: Make generator argument to Iterable.generate optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207823002: Make generator argument to Iterable.generate optional. (Closed)

Created:
6 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make generator argument to Iterable.generate optional. It defaults to an integer identity function. Also optimize skip/take on the generated iterable by making it take hold start and end positions instead of just the count. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34240

Patch Set 1 #

Patch Set 2 : Add tests. Fix bugs. #

Patch Set 3 : Changed contrustor to not throw on negative count, just cap it to zero. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -10 lines)			Patch
M	sdk/lib/core/iterable.dart	View	1	2 chunks	+39 lines, -9 lines	0 comments	Download
M	sdk/lib/internal/iterable.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/corelib/iterable_generate_test.dart	View	1 2	1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

6 years, 9 months ago (2014-03-21 09:54:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r34240 (presubmit successful).

Expand Messages | Collapse Messages