Issue 207693002: Don't print TODOs in Dart based analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207693002: Don't print TODOs in Dart based analyzer. (Closed)

Created:
6 years, 9 months ago by scheglov

Modified:
6 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't print TODOs in Dart based analyzer. Java based doesn't print them too. This improves dart2js analysis from 12500 to 11300 ms, i.e. about 1200 ms or 10%. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34254

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
	M	pkg/analyzer/lib/src/analyzer_impl.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	pkg/analyzer/lib/src/error_formatter.dart	View	1	1 chunk	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/207693002/diff/1/pkg/analyzer/lib/src/error_formatter.dart File pkg/analyzer/lib/src/error_formatter.dart (right): https://codereview.chromium.org/207693002/diff/1/pkg/analyzer/lib/src/error_formatter.dart#newcode12 pkg/analyzer/lib/src/error_formatter.dart:12: typedef bool _ErrorFilter(AnalysisError error); Perhaps document that the ...

6 years, 9 months ago (2014-03-21 13:23:00 UTC) #2

scheglov

Committed patchset #2 manually as r34254 (presubmit successful).

6 years, 9 months ago (2014-03-21 16:14:16 UTC) #3

scheglov

6 years, 9 months ago (2014-03-21 16:17:38 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/207693002/diff/1/pkg/analyzer/lib/src/error_f...
File pkg/analyzer/lib/src/error_formatter.dart (right):

https://codereview.chromium.org/207693002/diff/1/pkg/analyzer/lib/src/error_f...
pkg/analyzer/lib/src/error_formatter.dart:12: typedef bool
_ErrorFilter(AnalysisError error);
On 2014/03/21 13:23:00, Brian Wilkerson wrote:
> Perhaps document that the function is expected to return true when the error
> should be printed.

Done.

Expand Messages | Collapse Messages