Issue 20755004: Make sure that ICData always contains valid data (non-null values).

Issue 20755004: Make sure that ICData always contains valid data (non-null values). (Closed)

Created:
7 years, 4 months ago by srdjan

Modified:
7 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make sure that ICData always contains valid data (non-null values). R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25535

Patch Set 5 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -49 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	6 chunks	+35 lines, -40 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	7 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with comment addressed. https://codereview.chromium.org/20755004/diff/19002/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/20755004/diff/19002/runtime/vm/object.cc#newcode9281 runtime/vm/object.cc:9281: ASSERT(!target_name.IsNull()); ASSERT(!arguments_descriptor.IsNull());

7 years, 4 months ago (2013-07-26 19:11:20 UTC) #2

srdjan

https://codereview.chromium.org/20755004/diff/19002/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/20755004/diff/19002/runtime/vm/object.cc#newcode9281 runtime/vm/object.cc:9281: ASSERT(!target_name.IsNull()); On 2013/07/26 19:11:20, Cutch wrote: > ASSERT(!arguments_descriptor.IsNull()); Done.

7 years, 4 months ago (2013-07-26 19:42:00 UTC) #3

srdjan

7 years, 4 months ago (2013-07-26 20:17:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r25535 (presubmit successful).

Expand Messages | Collapse Messages