Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 207323004: Make the json_rpc_2 server test dart2js-compatible. (Closed)

Created:
6 years, 9 months ago by nweiz
Modified:
6 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the json_rpc_2 server test dart2js-compatible. R=rnystrom@google.com TBR Committed: https://code.google.com/p/dart/source/detail?r=34226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M pkg/json_rpc_2/test/server/server_test.dart View 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 9 months ago (2014-03-21 02:33:55 UTC) #1
nweiz
Committed patchset #1 manually as r34226 (presubmit successful).
6 years, 9 months ago (2014-03-21 02:34:10 UTC) #2
Bob Nystrom
How does this make dart2js happier?
6 years, 9 months ago (2014-03-21 17:27:42 UTC) #3
nweiz
On 2014/03/21 17:27:42, Bob Nystrom wrote: > How does this make dart2js happier? When we ...
6 years, 9 months ago (2014-03-21 19:40:17 UTC) #4
Bob Nystrom
6 years, 9 months ago (2014-03-21 19:43:16 UTC) #5
Message was sent while issue was closed.
Ah, thanks. LGTM.

Powered by Google App Engine
This is Rietveld 408576698