Issue 20722003: dart:io | Ensure that close() returns a Future<this> on all (Raw)?(Secure)?(Server)?Socket classes …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20722003: dart:io | Ensure that close() returns a Future<this> on all (Raw)?(Secure)?(Server)?Socket classes … (Closed)

Created:
7 years, 5 months ago by Bill Hesse

Modified:
7 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

dart:io | Ensure that close() returns a Future<this> on all (Raw)?(Secure)?(Server)?Socket classes and implementations. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25520

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -29 lines)			Patch
M	sdk/lib/async/future.dart	View	2 chunks	+41 lines, -17 lines	0 comments	Download
M	sdk/lib/io/secure_server_socket.dart	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	sdk/lib/io/socket.dart	View	3 chunks	+9 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

7 years, 4 months ago (2013-07-26 13:45:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25520 (presubmit successful).